[U-Boot] [PATCH][v4] powerpc: eSPI and eSPI controller support

[Xie Shaohui-B21989]

>-----Original Message-----
>From: Wolfgang Denk [mailto:wd at denx.de]
>Sent: Tuesday, April 26, 2011 2:51 PM
>To: Xie Shaohui-B21989
>Cc: u-boot at lists.denx.de; Gala Kumar-B11780
>Subject: Re: [U-Boot] [PATCH][v4] powerpc: eSPI and eSPI controller
>support
>
>Dear Shaohui Xie,
>
>In message <1303796554-29675-1-git-send-email-b21989 at freescale.com> you
>wrote:
>> From: Mingkai Hu <Mingkai.hu at freescale.com>
>>
>> Signed-off-by: Mingkai Hu <Mingkai.hu at freescale.com>
>> Singed-off-by: Jerry Huang <Chang-Ming.Huang at freescale.com>
>> Signed-off-by: Shaohui Xie <b21989 at freescale.com>
>> Cc: Mike Frysinger <vapier at gentoo.org>
>...
>> +		if (pm > 16) {
>> +			pm = 16;
>> +			debug("Requested speed is too low: %d Hz"
>> +			" %d Hz is used.\n", max_hz, spibrg / (32 * 16));
>
>Please indent continuation lines.
[Xie Shaohui] OK.
>
>...
>> +				/* Set up the next iteration if sending > 4 bytes
>*/
>
>Line to long.  Please fix globally.
[Xie Shaohui] OK.
>
>
>> --- a/include/spi.h
>> +++ b/include/spi.h
>> @@ -2,6 +2,8 @@
>>   * (C) Copyright 2001
>>   * Gerald Van Baren, Custom IDEAS, vanbaren at cideas.com.
>>   *
>> + * Copyright 2010-2011 Freescale Semiconductor, Inc
>> + *
>>   * See file CREDITS for list of people who contributed to this
>>   * project.
>>   *
>> @@ -26,13 +28,6 @@
>>
>>  /* Controller-specific definitions: */
>>
>> -/* CONFIG_HARD_SPI triggers SPI bus initialization in PowerPC */
>> -#ifdef CONFIG_MPC8XXX_SPI -# ifndef CONFIG_HARD_SPI -#  define
>> CONFIG_HARD_SPI -# endif -#endif
>> -
>>  /* SPI mode flags */
>>  #define	SPI_CPHA	0x01			/* clock phase */
>>  #define	SPI_CPOL	0x02			/* clock polarity */
>
>Please omit this part.  The deletion of 6 lines of code is not something
>which earns FSL any copyright.
>

[Xie Shaohui] OK, thanks, I'll wait to see if Mike has any comment for the rest of the patch, and resend a new version.



Best Regards, 
Shaohui Xie