[U-Boot] [PATCH v5] ARM: mx31: Print the silicon version

[Stefano Babic]

On 04/27/2011 11:11 AM, Detlev Zundel wrote:

>>>> This is due to the usage of the const in the mx3_cpu_type:
>>
>> struct mx3_cpu_type {
>>         u8 srev;
>>        const char *v;
>>
>> Do you agree if I drop myself the const attribute on u-boot-imx before
>> pulling your patch to the arm tree ?
> 
> Sorry to jump in late, 

.. not so late, we can change it...

>but why not change get_cpu_rev to 'const char *'
> which it actually is?

This is correct. However, I have not noted before that the last
introduced get_cpu_rev() in MX31 is an exception in u-boot. For all
other processors, it returns a u32 and it is defined as u32
get_cpu_rev(void).

Fabio's patch introduces a variant, because it is defined as const char
*get_cpu_rev(void). I propose to change its name (get_cpu_rev_string ?)
and add the static attribute, to make clear it is different as the
get_cpu_rev() already implemented in u-boot.

Stefano

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================