[U-Boot] [PATCH v5] ARM: mx31: Print the silicon version

[Fabio Estevam]

Hi Stefano,

On 4/27/2011 6:40 AM, Stefano Babic wrote:
...
>> but why not change get_cpu_rev to 'const char *'
>> which it actually is?
> 
> This is correct. However, I have not noted before that the last
> introduced get_cpu_rev() in MX31 is an exception in u-boot. For all
> other processors, it returns a u32 and it is defined as u32
> get_cpu_rev(void).
> 
> Fabio's patch introduces a variant, because it is defined as const char
> *get_cpu_rev(void). I propose to change its name (get_cpu_rev_string ?)
> and add the static attribute, to make clear it is different as the
> get_cpu_rev() already implemented in u-boot.

Ok, I can change it as per your suggestion.

Will send a patch soon.

Regards,

Fabio Estevam