[U-Boot] [PATCH 08/30] powerpc/km82xx: rename mgcoge2ne to mgcoge3ne board support

Wolfgang Denk wd at denx.de
Sat Apr 30 10:05:12 CEST 2011


Dear Valentin Longchamp,

In message <c5ba4fd44d7260d169b924ddda97c4a4c7460dd5.1302272395.git.valentin.longchamp at keymile.com> you wrote:
> From: Holger Brunck <holger.brunck at keymile.com>
> 
> This patch rename mgcoge2ne board support to mgcoge3ne.
> The board is similar to mgcoge. The difference is that
> a NUMONYX flash is used and a larger SDRAM (256MB).
> Also introduce CONFIG_KM_82XX to collect ppc82xx common
> settings.

I understand this is just a rename, but I want to ask anyway: if flash
type and RAM size are the only differences, then why do we need two
separate board definitions here?

Would not even the same U-Boot binary image run on both boards?  These
flashes are CFI compatible, so the CFI driver would work on both, and
RAM size autodetection has been available in U-Boot forever.

In worst case, we coul differentiate boards by an additional #define,
which means we only need a single line entry in boards.cfg.

Why do we need to support two board entries?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Military secrets are the most fleeting of all.
	-- Spock, "The Enterprise Incident", stardate 5027.4


More information about the U-Boot mailing list