[U-Boot] [PATCH] CPCI750: Fix GCC 4.6 warning in board/esd/cpci750/mv_eth.c

[Wolfgang Denk]

Dear Reinhard Arlt,

In message <4EC6A749.1020304 at esd.eu> you wrote:
> From: Reinhard Arlt <reinhard.arlt at esd.eu>
> 
> This patch fix the GCC 4.6 warnings in 

in what?

and which warnings?

> Signed-off-by: Reinhard Arlt <reinhard.arlt at esd.eu>
> 
> --
> 
> diff --git a/board/esd/cpci750/mv_eth.c b/board/esd/cpci750/mv_eth.c
> index 781ad23..69b4a91 100644
> --- a/board/esd/cpci750/mv_eth.c
> +++ b/board/esd/cpci750/mv_eth.c
> @@ -100,6 +100,8 @@ extern void NetReceive (volatile uchar *, int);
>  
>  extern unsigned int INTERNAL_REG_BASE_ADDR;
>  
> +u32 port_status;

What is this needed for?

I see a port_status locally used in mv64360_eth_print_phy_status(),
but except from that it never gets read.

Sorry, but his does not appear to be a good fix.

You may want to have a look at what I did to the same driver for the
Marvell boards.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Though a program be but three lines long,
someday it will have to be maintained."
- The Tao of Programming