[U-Boot] [RFC PATCH 6/7] reboard: arm: Move over to generic relocation

[Simon Glass]

Hi Mike,

On Mon, Nov 28, 2011 at 7:14 PM, Mike Frysinger <vapier at gentoo.org> wrote:
> On Monday 21 November 2011 18:57:59 Simon Glass wrote:
>> --- a/board/reloc.c
>> +++ b/board/reloc.c
>>
>> -void relocate_code(ulong dest_addr_sp, gd_t *new_gd, ulong dest_addr)
>> +void new_relocate_code(ulong dest_addr_sp, gd_t *new_gd, ulong dest_addr)
>
> shouldn't this be squashed into the patch that added this func ?

Yes I'm going with the weak function idea. We can remove it when all
archs are moved over.

>
>> --- a/nand_spl/board/freescale/mx31pdk/Makefile
>> +++ b/nand_spl/board/freescale/mx31pdk/Makefile
>>
>> +$(obj)%.o:   $(SRCTREE)/board/%.c
>> +     $(CC) $(CFLAGS) -c -o $@ $<
>> +
>> +$(obj)%.o:   $(SRCTREE)/arch/arm/lib/%.S
>> +     $(CC) $(AFLAGS) -c -o $@ $<
>
> ugh.  is this the SOP for SPL or something ?  this is awful :(.

Yes, SPL. It makes me very sad too. The worse alternative is to break
all boards that don't use the new SPL framework.

Regards,
Simon

> -mike