[U-Boot] [PATCH 02/19] usbdev.c: Fix GCC 4.6 build warnings

Wolfgang Denk wd at denx.de
Fri Dec 9 10:31:01 CET 2011


Dear Stefan Roese,

In message <1321380112-6210-1-git-send-email-sr at denx.de> you wrote:
> Fix:
> usbdev.c: In function 'process_endpoints':
> usbdev.c:29:12: warning: variable 'temp1' set but not used [-Wunused-but-set-variable]
> usbdev.c:29:6: warning: variable 'temp' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: Stefan Roese <sr at denx.de>
...
> @@ -44,8 +43,6 @@ void process_endpoints(unsigned short usb2d0_intrin)
>  		/*copy packet */
>  		setup_packet_pt[0] = *(unsigned int *)USB2D0_FIFO_0;
>  		setup_packet_pt[1] = *(unsigned int *)USB2D0_FIFO_0;
> -		temp = *(unsigned int *)USB2D0_FIFO_0;
> -		temp1 = *(unsigned int *)USB2D0_FIFO_0;

It seems we agree that these reads from the FIFO registers may
actually be important for proper operation. Are you planning to
submit an updated, improved patch?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Is truth not truth for all?
	-- Natira, "For the World is Hollow and I have Touched
		   the Sky", stardate 5476.4.


More information about the U-Boot mailing list