[U-Boot] [PATCH 02/19] usbdev.c: Fix GCC 4.6 build warnings

Stefan Roese sr at denx.de
Fri Dec 9 10:44:03 CET 2011


Hi Wolfgang,

On Friday 09 December 2011 10:31:01 Wolfgang Denk wrote:
> In message <1321380112-6210-1-git-send-email-sr at denx.de> you wrote:
> > Fix:
> > usbdev.c: In function 'process_endpoints':
> > usbdev.c:29:12: warning: variable 'temp1' set but not used
> > [-Wunused-but-set-variable] usbdev.c:29:6: warning: variable 'temp' set
> > but not used [-Wunused-but-set-variable]
> > 
> > Signed-off-by: Stefan Roese <sr at denx.de>
> 
> ...
> 
> > @@ -44,8 +43,6 @@ void process_endpoints(unsigned short usb2d0_intrin)
> > 
> >  		/*copy packet */
> >  		setup_packet_pt[0] = *(unsigned int *)USB2D0_FIFO_0;
> >  		setup_packet_pt[1] = *(unsigned int *)USB2D0_FIFO_0;
> > 
> > -		temp = *(unsigned int *)USB2D0_FIFO_0;
> > -		temp1 = *(unsigned int *)USB2D0_FIFO_0;
> 
> It seems we agree that these reads from the FIFO registers may
> actually be important for proper operation. Are you planning to
> submit an updated, improved patch?

This file has been removed with patch ce2acd371c4eee36e55d706a181361c25ebfe160 
already in mainline.

Best regards,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de


More information about the U-Boot mailing list