[U-Boot] [PATCH v2] tools/setlocalversion: Update from the Linux Kernel

Moffett, Kyle D Kyle.D.Moffett at boeing.com
Fri Dec 16 18:55:02 CET 2011


On Dec 16, 2011, at 11:07, Mike Frysinger wrote:
> On Thursday 15 December 2011 21:13:55 Kyle Moffett wrote:
>> The version from the kernel is not directly usable as it has code for
>> supporting CONFIG_LOCALVERSION from Kconfig, but the version that was
>> imported is very similar to the one in Linux v3.2-rc4.
> 
> NAK: this breaks localversion-* support

Ah, I missed that somehow.  I'd read through the U-Boot version and did
not remember seeing that part so I assumed it wasn't necessary.


> ignoring that, i'm not sure you really need to delete the CONFIG_xxx handling.  
> under u-boot, they'd expand to like "" which would end at the same code.  by 
> keeping as much code as possible in common, it should make future updates 
> easier.

Ok, I will respin, retest, and resubmit as you suggest.

Cheers,
Kyle Moffett

--
Curious about my work on the Debian powerpcspe port?
I'm keeping a blog here: http://pureperl.blogspot.com/



More information about the U-Boot mailing list