[U-Boot] [PATCH] mpc8xxx: Fix "DRAM" message formatting

Wolfgang Denk wd at denx.de
Sat Dec 17 21:12:10 CET 2011


Dear Kyle Moffett,

In message <1324001689-15226-1-git-send-email-Kyle.D.Moffett at boeing.com> you wrote:
> When the "Detected RDIMM [...]" message was added, it broke the
> pretty-printing of the DRAM information during boot.
> 
> It used to look like this:
>   DRAM:  2 GiB (DDR2, 64-bit, CL=4, ECC on)
>          DDR Chip-Select Interleaving Mode: CS0+CS1
> 
> Right now, it looks like this:
>   DRAM:  Detected RDIMM VL493T5663D-E6M
>   2 GiB (DDR2, 64-bit, CL=4, ECC on)
>          DDR Chip-Select Interleaving Mode: CS0+CS1
> 
> After this patch, it is:
>   DRAM:  Detected RDIMM VL493T5663D-E6M
>          2 GiB (DDR2, 64-bit, CL=4, ECC on)
>          DDR Chip-Select Interleaving Mode: CS0+CS1

We discussed this before.

This outpout is too verbose.  It should read:

	DRAM:  2 GiB

And not more.  Any additional information should only be printed upon
explicit request from the user.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A verbal contract isn't worth the paper it's written on.
                                                    -- Samuel Goldwyn


More information about the U-Boot mailing list