[U-Boot] [PATCH] s5p-mmc: Fix ambiguous setting of data transfer width

Wolfgang Denk wd at denx.de
Thu Sep 1 07:51:05 CEST 2011


Dear Minkyu Kang,

In message <CALrBrZ3H+k8bu-1OwF5C5BNHuphj_J8jXXV2xgu6jPO5gmJELg at mail.gmail.com> you wrote:
> 
> > I know these were like this before, but those numbers are awfully
> > magical. You should really define constants for them.
> 
> We decided to use comments instead of defines.

And now we ask you to fix this, because we don;t want such magic
constants.  So please go on and change this.

Thanks.

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
About the use of language: it is impossible to sharpen a pencil  with
a  blunt  ax.  It is equally vain to try to do it with ten blunt axes
instead.                                           -- Edsger Dijkstra


More information about the U-Boot mailing list