[U-Boot] [PATCH] s5p-mmc: Fix ambiguous setting of data transfer width

Minkyu Kang promsoft at gmail.com
Fri Sep 2 10:09:33 CEST 2011


Dear Wolfgang Denk,

On 1 September 2011 14:51, Wolfgang Denk <wd at denx.de> wrote:
> Dear Minkyu Kang,
>
> In message <CALrBrZ3H+k8bu-1OwF5C5BNHuphj_J8jXXV2xgu6jPO5gmJELg at mail.gmail.com> you wrote:
>>
>> > I know these were like this before, but those numbers are awfully
>> > magical. You should really define constants for them.
>>
>> We decided to use comments instead of defines.
>
> And now we ask you to fix this, because we don;t want such magic
> constants.  So please go on and change this.
>

OK.

Thanks.
Minkyu Kang
-- 
from. prom.
www.promsoft.net


More information about the U-Boot mailing list