[U-Boot] [PATCH v3] ns16550: change to allow 32 bit access to registers

Tabi Timur-B04825 B04825 at freescale.com
Thu Sep 1 17:39:51 CEST 2011


On Thu, Sep 1, 2011 at 6:40 AM, Dave Aldridge <fovsoft at gmail.com> wrote:

>  #if !defined(CONFIG_SYS_NS16550_REG_SIZE) || (CONFIG_SYS_NS16550_REG_SIZE == 0)
>  #error "Please define NS16550 registers size."
> +#elif defined(CONFIG_SYS_NS16550_MEM32)
> +#define UART_REG(x) unsigned int x;

Shouldn't this be

#define UART_REG(x) u32 x

For one thing, I think you want a sized integer.  Secondly, does the
semicolon at the end belong there?

-- 
Timur Tabi
Linux kernel developer at Freescale


More information about the U-Boot mailing list