[U-Boot] [PATCH] UBIFS: Change ubifsload to set the filesize variable

Wolfgang Denk wd at denx.de
Mon Sep 5 16:27:28 CEST 2011


Dear Marek Vasut,

In message <201109051512.48148.marek.vasut at gmail.com> you wrote:
>
> > +	setenv("filesize", buf);
> 
> maybe you want to check set_local_var() too ?

Yes, we should clean up all these auto-generated environment variables
one day.  But what you propose here is not a good approach:

(1) not all boards use the hush shell, and set_local_var() is only
    available there.
(2) if you make such a change, then you must make it everywhere, and
    you must make sure not to break existent use of these things.

Both is definitely out of the scope of this patch.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Quote from a recent meeting:   "We are going to continue having these
meetings everyday until I find out why no work is getting done."


More information about the U-Boot mailing list