[U-Boot] [PATCH] UBIFS: Change ubifsload to set the filesize variable

Marek Vasut marek.vasut at gmail.com
Mon Sep 5 17:04:45 CEST 2011


On Monday, September 05, 2011 04:27:28 PM Wolfgang Denk wrote:
> Dear Marek Vasut,
> 
> In message <201109051512.48148.marek.vasut at gmail.com> you wrote:
> > > +	setenv("filesize", buf);
> > 
> > maybe you want to check set_local_var() too ?
> 
> Yes, we should clean up all these auto-generated environment variables
> one day.  But what you propose here is not a good approach:
> 
> (1) not all boards use the hush shell, and set_local_var() is only
>     available there.
> (2) if you make such a change, then you must make it everywhere, and
>     you must make sure not to break existent use of these things.
> 
> Both is definitely out of the scope of this patch.

You're definitelly right on this thing.

> 
> Best regards,
> 
> Wolfgang Denk


More information about the U-Boot mailing list