[U-Boot] [PATCH 3/7] Add timing information to printf's for use with bootgraph.pl

Wolfgang Denk wd at denx.de
Wed Sep 7 23:10:03 CEST 2011


Dear Mike Frysinger,

In message <201108311847.16042.vapier at gentoo.org> you wrote:
>
> NAK for a few reasons:
>  - i dont see how this could possibly compile warning free
>  - you never initialize "i", only added to it
>  - you call va_start() inbetween variable decls

Could you _please_ accustom yourself to updating the status in
patchwork to "changes requested"  when sending revierw comments like
here?


I think I asked this a couple of times before...

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
: 1.  What is the possibility of this being added in the future?
In the near future, the probability is close to zero. In the  distant
future, I'll be dead, and posterity can do whatever they like... :-)
                                                              - lwall


More information about the U-Boot mailing list