[U-Boot] [PATCH 3/7] Add timing information to printf's for use with bootgraph.pl

Mike Frysinger vapier at gentoo.org
Fri Sep 9 02:50:50 CEST 2011


On Wednesday, September 07, 2011 17:10:03 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > NAK for a few reasons:
> >  - i dont see how this could possibly compile warning free
> >  - you never initialize "i", only added to it
> >  - you call va_start() inbetween variable decls
> 
> Could you _please_ accustom yourself to updating the status in
> patchwork to "changes requested"  when sending revierw comments like
> here?

be nice if patchwork itself would key off a tag we could use in our e-mails 
and auto set the status ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110908/6d7f6782/attachment.pgp 


More information about the U-Boot mailing list