[U-Boot] [PATCH] led: remove camelcase in LED functions from assembly

Albert ARIBAUD albert.u.boot at aribaud.net
Mon Sep 12 17:40:27 CEST 2011


Le 12/09/2011 07:31, Albert ARIBAUD a écrit :
> Hi Mike,
>
> Le 12/09/2011 06:04, Mike Frysinger a écrit :
>> On Sunday, September 11, 2011 18:22:26 Jason Kridner wrote:
>>> This was done with the following command-line:
>>>
>>> for file in `find . | grep '\.[chS]$'`;
>>>    do perl -i -pe 's/(green|yellow|red|blue)_LED_(on|off)/$1_led_$2/g' $file;
>>> done
>>
>> one line:
>> find . -name '*.[chS]' -exec \
>> 	sed -ri 's/(green|yellow|red|blue)_LED_(on|off)/\1_led_\2/g'
>>
>>> --- a/arch/arm/cpu/arm1176/start.S
>>> +++ b/arch/arm/cpu/arm1176/start.S
>>>
>>>    	bl coloured_LED_init
>>> -	bl red_LED_on
>>> +	bl red_led_on
>>
>> seems like you didnt fix coloured_LED_init
>>
>> also, i dont see you changing any of the .c files where these funcs are
>> actually defined
>> -mike
>
> This patch is assumed to apply above the current git tip, where the
> function definitions were already changed, and only .S files should be
> fixed.
>
> Running MAKEALL arm right now, just to make sure, then I will apply it
> on top of u-boot-arm/master.

Applied to u-boot-arm/master, thanks -- and the non-clean ARM boards 
count is down to 29 out of 242.

Amicalement,
-- 
Albert.


More information about the U-Boot mailing list