[U-Boot] [PATCH] led: remove camelcase in LED functions from assembly

Mike Frysinger vapier at gentoo.org
Mon Sep 12 18:27:20 CEST 2011


On Monday, September 12, 2011 01:31:45 Albert ARIBAUD wrote:
> Le 12/09/2011 06:04, Mike Frysinger a écrit :
> > On Sunday, September 11, 2011 18:22:26 Jason Kridner wrote:
> >> This was done with the following command-line:
> >> 
> >> for file in `find . | grep '\.[chS]$'`;
> >> 
> >>   do perl -i -pe 's/(green|yellow|red|blue)_LED_(on|off)/$1_led_$2/g'
> >>   $file;
> >> 
> >> done
> > 
> > one line:
> > find . -name '*.[chS]' -exec \
> > 
> > 	sed -ri 's/(green|yellow|red|blue)_LED_(on|off)/\1_led_\2/g'
> > 	
> >> --- a/arch/arm/cpu/arm1176/start.S
> >> +++ b/arch/arm/cpu/arm1176/start.S
> >> 
> >>   	bl coloured_LED_init
> >> 
> >> -	bl red_LED_on
> >> +	bl red_led_on
> > 
> > seems like you didnt fix coloured_LED_init
> > 
> > also, i dont see you changing any of the .c files where these funcs are
> > actually defined
> 
> This patch is assumed to apply above the current git tip, where the
> function definitions were already changed, and only .S files should be
> fixed.

by "current git tip" i'm guessing you mean "current arm master".  i was 
looking at the mainline u-boot master and the C files weren't changed.

> Running MAKEALL arm right now, just to make sure, then I will apply it
> on top of u-boot-arm/master.

be nice to send out a single squashed patch to wolfgang rather than a few 
known-to-be-broken ones ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110912/b64a0921/attachment.pgp 


More information about the U-Boot mailing list