[U-Boot] [PATCH] net/bootp.c: fix tftp load if autoload environment var isn't set

[Simon Glass]

Hi Peter,

On Mon, Sep 19, 2011 at 6:47 AM, Fabio Estevam <festevam at gmail.com> wrote:
> On Mon, Sep 19, 2011 at 4:54 AM, Peter Korsgaard <jacmet at sunsite.dk> wrote:
>> Commit 093498669 (Put common autoload code into auto_load() function)
>> broke handling of autoload environment variable not being set.
>> The bootp/dhcp code will just keep on requesting IP address forever
>> and never start TFTP download.
>>
>> Fix it by moving TftpStart() outside the conditional like it was before.
>>
>> Signed-off-by: Peter Korsgaard <jacmet at sunsite.dk>
>
> This makes mx31pdk networking to work again at my company's network.
>
> Tested-by: Fabio Estevam <fabio.estevam at freescale.com>

I think we just had this discussion at the end of August. It would be
good to get to the bottom of why this commit is considered a change of
behaviour - it is something subtle that I cannot see.

But first: if autoload is not defined, it is supposed to default to
'y'. If you want it to be 'n' then you need to set it. It that what
you expect?

Regards,
Simon

>
> Thanks,
>
> Fabio Estevam
>