[U-Boot] [PATCH] net/bootp.c: fix tftp load if autoload environment var isn't set

Peter Korsgaard jacmet at sunsite.dk
Mon Sep 19 17:29:24 CEST 2011


>>>>> "Simon" == Simon Glass <sjg at chromium.org> writes:

Hi,

 Simon> I think we just had this discussion at the end of August. It
 Simon> would be good to get to the bottom of why this commit is
 Simon> considered a change of behaviour - it is something subtle that I
 Simon> cannot see.

Because with that commit it no longer calls TftpStart() if the autoload
variable isn't set (it moved into the if (getenv..) conditional).

 Simon> But first: if autoload is not defined, it is supposed to default to
 Simon> 'y'. If you want it to be 'n' then you need to set it. It that what
 Simon> you expect?

Yes, no autoload should behave like autoload=y, E.G. call TftpStart().

-- 
Bye, Peter Korsgaard


More information about the U-Boot mailing list