[U-Boot] [PATCH] net/bootp.c: fix tftp load if autoload environment var isn't set

Simon Glass sjg at chromium.org
Mon Sep 19 17:48:47 CEST 2011


Hi Peter,

On Mon, Sep 19, 2011 at 8:29 AM, Peter Korsgaard <jacmet at sunsite.dk> wrote:
>>>>>> "Simon" == Simon Glass <sjg at chromium.org> writes:
>
> Hi,
>
>  Simon> I think we just had this discussion at the end of August. It
>  Simon> would be good to get to the bottom of why this commit is
>  Simon> considered a change of behaviour - it is something subtle that I
>  Simon> cannot see.
>
> Because with that commit it no longer calls TftpStart() if the autoload
> variable isn't set (it moved into the if (getenv..) conditional).

OK I see thank you.

>
>  Simon> But first: if autoload is not defined, it is supposed to default to
>  Simon> 'y'. If you want it to be 'n' then you need to set it. It that what
>  Simon> you expect?
>
> Yes, no autoload should behave like autoload=y, E.G. call TftpStart().

Acked-by: Simon Glass <sjg at chromium.org>

Regards,
Simon
>
> --
> Bye, Peter Korsgaard
>


More information about the U-Boot mailing list