[U-Boot] [PATCH] image: push default arch values to arch headers

Wolfgang Denk wd at denx.de
Mon Sep 26 19:58:59 CEST 2011


Dear Mike Frysinger,

In message <201109261209.46800.vapier at gentoo.org> you wrote:
>
> > ...here you change a compile time error check into a runtim error.
> 
> no, it'll still be a build time error as IH_ARCH_DEFAULT will be undefined
> 
> it just might not be as clean an error ... gcc will complain about 
> IH_ARCH_DEFAULT not being defined rather than a helpful "Unknown CPU type"

Should it not be trivial to add a

	#ifndef IH_ARCH_DEFAULT
	# error Unknown CPU type: IH_ARCH_DEFAULT not set
	#endif

or similar to include/image.h ?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Children are natural mimics who act like their parents despite  every
effort to teach them good manners.


More information about the U-Boot mailing list