[U-Boot] [PATCH] image: push default arch values to arch headers

Mike Frysinger vapier at gentoo.org
Mon Sep 26 20:15:13 CEST 2011


On Monday, September 26, 2011 13:58:59 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > > ...here you change a compile time error check into a runtim error.
> > 
> > no, it'll still be a build time error as IH_ARCH_DEFAULT will be
> > undefined
> > 
> > it just might not be as clean an error ... gcc will complain about
> > IH_ARCH_DEFAULT not being defined rather than a helpful "Unknown CPU
> > type"
> 
> Should it not be trivial to add a
> 
> 	#ifndef IH_ARCH_DEFAULT
> 	# error Unknown CPU type: IH_ARCH_DEFAULT not set
> 	#endif
> 
> or similar to include/image.h ?

it'd certainly be easy to do.  i just pointed out that you still get a build 
failure after my change :).  so if you want the #error, i'll resend w/it.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110926/9a1f3d90/attachment.pgp 


More information about the U-Boot mailing list