[U-Boot] U-Boot build break for m501sk board from Artila

[Wolfgang Denk]

Dear Jamie,

In message <loom.20110927T050021-301 at post.gmane.org> you wrote:
> 
> > Not anymore. Because no one fixed this board in the last two years, the
> > board was removed from U-Boot mainline. It is not supported.
...
> That's too bad.  I've been developing for the board for the past 3 years and 
> only recently have been given the opportunity to re-examine the loader and root 
> file system. 

It would be trivial to re-add the board if there is someone who
actively maintains the related code.

>  #if defined(CONFIG_AT91RM9200)
> -# include <asm/arch/at91rm9200.h>
> +# include <asm/arch-at91/at91rm9200.h>
>  #elif defined(CONFIG_AT91SAM9260) || defined(CONFIG_AT91SAM9G20) || \
>         defined(CONFIG_AT91SAM9XE)
> -# include <asm/arch/at91sam9260.h>
> +# include <asm/arch-at91/at91sam9260.h>
>  #elif defined(CONFIG_AT91SAM9261) || defined(CONFIG_AT91SAM9G10)
> -# include <asm/arch/at91sam9261.h>
> +# include <asm/arch-at91/at91sam9261.h>
>  #elif defined(CONFIG_AT91SAM9263)
> -# include <asm/arch/at91sam9263.h>
> +# include <asm/arch-at91/at91sam9263.h>
>  #elif defined(CONFIG_AT91SAM9RL)
> -# include <asm/arch/at91sam9rl.h>
> +# include <asm/arch-at91/at91sam9rl.h>
>  #elif defined(CONFIG_AT91SAM9G45) || defined(CONFIG_AT91SAM9M10G45)
> -# include <asm/arch/at91sam9g45.h>
> +# include <asm/arch-at91/at91sam9g45.h>
>  #elif defined(CONFIG_AT91CAP9)
> -# include <asm/arch/at91cap9.h>
> +# include <asm/arch-at91/at91cap9.h>
>  #elif defined(CONFIG_AT91X40)
> -# include <asm/arch/at91x40.h>
> +# include <asm/arch-at91/at91x40.h>

All these modifications are bogus and should be removed.  They are not
needed either.

> diff --git a/include/configs/m501sk.h b/include/configs/m501sk.h
> index 68f0415..55b9154 100644
> --- a/include/configs/m501sk.h
> +++ b/include/configs/m501sk.h
> @@ -162,7 +162,9 @@
> 
>  #define CONFIG_NR_DRAM_BANKS   1
>  #define PHYS_SDRAM             0x20000000
> -#define PHYS_SDRAM_SIZE        0x2000000 /* 32 megs */
> +#define PHYS_SDRAM_SIZE                0x4000000 /* 64 megs */
> +#define CONFIG_SYS_SDRAM_BASE  PHYS_SDRAM
> +#define CONFIG_SYS_INIT_SP_ADDR        (PHYS_SDRAM + (PHYS_SDRAM_SIZE >> 13))

This is a highly cryptic way to say "+ 8192" - is there any rationale
for such an unreadable way to express this?

>  #define CONFIG_SYS_MEMTEST_START       0x21000000 /* PHYS_SDRAM */
>  /* CONFIG_SYS_MEMTEST_START + PHYS_SDRAM_SIZE - 262144 */

Hm - after reverting commit b1a2bd4 and then applying your patches, I
still get:

Configuring for m501sk board...
make[1]: *** No targets specified and no makefile found.  Stop.
make: *** [arch/arm/cpu/arm920t/at91rm9200/libat91rm9200.o] Error 2

Sorry, this does not work.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The connection between the language in which we think/program and the
problems and solutions we can imagine is very close. For this  reason
restricting  language  features  with  the intent of eliminating pro-
grammer errors is at best dangerous.
               - Bjarne Stroustrup in "The  C++ Programming Language"