[U-Boot] [PATCH] i.MX28: Fix initial stack pointer position

Marek Vasut marex at denx.de
Mon Apr 2 06:21:34 CEST 2012


The patch:

  m28evk: Use GENERATED_GBL_DATA_SIZE
  commit 1084606c972ea5f1d89f69bdbd978b867d0ee521

introduced usage of GENERATED_GBL_DATA_SIZE and calculation of initial stack
pointer position defived from that. Due to a small typo, the SP position moved
to 0x21f80, which is past the SRAM area. This didn't manifest on the real
hardware as the SRAM repeats there (address bits in the CPU being ignored).

Though this was caught in QEMU, where it crashed the emulator.

Signed-off-by: Marek Vasut <marex at denx.de>
Cc: Stefano Babic <sbabic at denx.de>
Cc: Fabio Estevam <fabio.estevam at freescale.com>
---
 include/configs/m28evk.h  |    2 +-
 include/configs/mx28evk.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

NOTE: I'll get a Tested-by on M28EVK ASAP, probably on wednesday.

diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h
index 9de4521..8526dd4 100644
--- a/include/configs/m28evk.h
+++ b/include/configs/m28evk.h
@@ -96,7 +96,7 @@
 #define	CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
 /* Point initial SP in SRAM so SPL can use it too. */
 
-#define CONFIG_SYS_INIT_RAM_ADDR	0x00002000
+#define CONFIG_SYS_INIT_RAM_ADDR	0x00000000
 #define CONFIG_SYS_INIT_RAM_SIZE	(128 * 1024)
 
 #define CONFIG_SYS_INIT_SP_OFFSET \
diff --git a/include/configs/mx28evk.h b/include/configs/mx28evk.h
index 705fdab..02f3366 100644
--- a/include/configs/mx28evk.h
+++ b/include/configs/mx28evk.h
@@ -81,7 +81,7 @@
 #define CONFIG_SYS_SDRAM_BASE		PHYS_SDRAM_1
 /* Point initial SP in SRAM so SPL can use it too. */
 
-#define CONFIG_SYS_INIT_RAM_ADDR	0x00002000
+#define CONFIG_SYS_INIT_RAM_ADDR	0x00000000
 #define CONFIG_SYS_INIT_RAM_SIZE	(128 * 1024)
 
 #define CONFIG_SYS_INIT_SP_OFFSET \
-- 
1.7.9.1



More information about the U-Boot mailing list