[U-Boot] [PATCH] m28evk: Use GENERATED_GBL_DATA_SIZE
Marek Vasut
marex at denx.de
Mon Apr 2 06:17:01 CEST 2012
Dear Fabio Estevam,
I think this patch is wrong ... did I ack this one?
> Use GENERATED_GBL_DATA_SIZE for calculating CONFIG_SYS_INIT_SP_OFFSET.
>
> Signed-off-by: Fabio Estevam <fabio.estevam at freescale.com>
> ---
> include/configs/m28evk.h | 9 ++++++++-
> 1 files changed, 8 insertions(+), 1 deletions(-)
>
> diff --git a/include/configs/m28evk.h b/include/configs/m28evk.h
> index 39c841f..2b4871e 100644
> --- a/include/configs/m28evk.h
> +++ b/include/configs/m28evk.h
> @@ -92,7 +92,14 @@
> #define CONFIG_SYS_MEMTEST_END 0x40400000 /* 4 MB RAM test
*/
> #define CONFIG_SYS_SDRAM_BASE PHYS_SDRAM_1
> /* Point initial SP in SRAM so SPL can use it too. */
> -#define CONFIG_SYS_INIT_SP_ADDR 0x00002000
> +
> +#define CONFIG_SYS_INIT_RAM_ADDR 0x00002000
This 0x2000 is wrong, it should be 0x0. Otherwise your maths below overflow and
SP is located at 0x21f80.
> +#define CONFIG_SYS_INIT_RAM_SIZE (128 * 1024)
> +
> +#define CONFIG_SYS_INIT_SP_OFFSET \
> + (CONFIG_SYS_INIT_RAM_SIZE - GENERATED_GBL_DATA_SIZE)
> +#define CONFIG_SYS_INIT_SP_ADDR \
> + (CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_INIT_SP_OFFSET)
> /*
> * We need to sacrifice first 4 bytes of RAM here to avoid triggering some
> * strange BUG in ROM corrupting first 4 bytes of RAM when loading U-Boot
Best regards,
Marek Vasut
More information about the U-Boot
mailing list