[U-Boot] [PATCH v2 08/10] net: cosmetic: sntp.* checkpatch compliance

[Simon Glass]

On Tue, Mar 27, 2012 at 4:42 PM, Joe Hershberger <joe.hershberger at ni.com> wrote:
> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Joe Hershberger <joe.hershberger at gmail.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Mike Frysinger <vapier at gentoo.org>

Acked-by: Simon Glass <sjg at chromium.org>

but see suggestion below (not checkpatch issue though)

> ---
> Changes for v2:
>   - Split into smaller patches
>
>  net/sntp.c |   31 +++++++++++++++++--------------
>  net/sntp.h |    2 +-
>  2 files changed, 18 insertions(+), 15 deletions(-)
>
> diff --git a/net/sntp.c b/net/sntp.c
> index 82f2fe6..6dd0dbd 100644
> --- a/net/sntp.c
> +++ b/net/sntp.c

> @@ -77,13 +80,13 @@ SntpHandler(uchar *pkt, unsigned dest, IPaddr_t sip, unsigned src,
>  }
>
>  void
> -SntpStart (void)
> +SntpStart(void)
>  {
>        debug("%s\n", __func__);
>
> -       NetSetTimeout (SNTP_TIMEOUT, SntpTimeout);
> +       NetSetTimeout(SNTP_TIMEOUT, SntpTimeout);
>        NetSetHandler(SntpHandler);
> -       memset (NetServerEther, 0, 6);
> +       memset(NetServerEther, 0, 6);

sizeof(NetServerEther) might be better.

>
> -       SntpSend ();
> +       SntpSend();
>  }
> diff --git a/net/sntp.h b/net/sntp.h
> index 8a097bf..1d0046e 100644
> --- a/net/sntp.h
> +++ b/net/sntp.h
> @@ -56,6 +56,6 @@ struct sntp_pkt_t {
>        unsigned long long transmit_timestamp;
>  };
>
> -extern void    SntpStart (void);       /* Begin SNTP */
> +extern void SntpStart(void);   /* Begin SNTP */
>
>  #endif /* __SNTP_H__ */
> --
> 1.6.0.2
>