[U-Boot] [PATCH v2 09/10] net: cosmetic: tftp.* checkpatch compliance

Simon Glass sjg at chromium.org
Mon Apr 2 08:12:29 CEST 2012


Hi Joe,

On Tue, Mar 27, 2012 at 4:42 PM, Joe Hershberger <joe.hershberger at ni.com> wrote:
> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Joe Hershberger <joe.hershberger at gmail.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Mike Frysinger <vapier at gentoo.org>

Acked-by: Simon Glass <sjg at chromium.org>

> ---
> Changes for v2:
>   - Split into smaller patches
>
>  include/net.h |    4 ++++
>  net/tftp.c    |   30 ++++++++++++++----------------
>  net/tftp.h    |    2 +-
>  3 files changed, 19 insertions(+), 17 deletions(-)
>
> @@ -157,7 +155,7 @@ mcast_cleanup(void)
>
>  #endif /* CONFIG_MCAST_TFTP */
>
> -static __inline__ void
> +static inline void
>  store_block(unsigned block, uchar *src, unsigned len)

Q: Do we really need this inline?

Regards,
Simon


More information about the U-Boot mailing list