[U-Boot] [PATCH 3/3] net/tsec: Don't tell the link status if used with netconsole

Mike Frysinger vapier at gentoo.org
Tue Apr 3 22:42:23 CEST 2012


On Friday 23 March 2012 16:11:19 Sebastian Andrzej Siewior wrote:
> --- a/drivers/net/tsec.c
> +++ b/drivers/net/tsec.c
> 
> +	if (strcmp(getenv("stdout"), "nc"))

i really don't like special casing devices like this

> -	serial_printf("Speed: %d, %s duplex%s\n", phydev->speed,
> -			(phydev->duplex) ? "full" : "half",
> -			(phydev->port == PORT_FIBRE) ? ", fiber mode" : "");
> +		serial_printf("Speed: %d, %s duplex%s\n", phydev->speed,
> +				(phydev->duplex) ? "full" : "half",
> +				(phydev->port == PORT_FIBRE) ? ", fiber mode"
> +				: "");

why not just delete this line completely ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120403/6e0ba6f0/attachment.pgp>


More information about the U-Boot mailing list