[U-Boot] [PATCH 3/3] net/tsec: Don't tell the link status if used with netconsole

Sebastian Andrzej Siewior bigeasy at linutronix.de
Tue Apr 3 22:54:23 CEST 2012


On 04/03/2012 10:42 PM, Mike Frysinger wrote:
> On Friday 23 March 2012 16:11:19 Sebastian Andrzej Siewior wrote:
>> --- a/drivers/net/tsec.c
>> +++ b/drivers/net/tsec.c
>>
>> +	if (strcmp(getenv("stdout"), "nc"))
>
> i really don't like special casing devices like this
>
>> -	serial_printf("Speed: %d, %s duplex%s\n", phydev->speed,
>> -			(phydev->duplex) ? "full" : "half",
>> -			(phydev->port == PORT_FIBRE) ? ", fiber mode" : "");
>> +		serial_printf("Speed: %d, %s duplex%s\n", phydev->speed,
>> +				(phydev->duplex) ? "full" : "half",
>> +				(phydev->port == PORT_FIBRE) ? ", fiber mode"
>> +				: "");
>
> why not just delete this line completely ?

*I* don't mind but others might complain about missing important
information. So in my re-do of the series I remove it instead and see
what happens.

> -mike

Sebastian


More information about the U-Boot mailing list