[U-Boot] [PATCH v2 09/21] net: cosmetic: Un-typedef IP_t

Simon Glass sjg at chromium.org
Fri Apr 27 02:06:28 CEST 2012


Hi Joe,

On Wed, Mar 28, 2012 at 12:42 PM, Joe Hershberger <joe.hershberger at ni.com>wrote:

> Rename IP header related things to IP_UDP. The existing definition
> of IP_t includes UDP header, so name it to accurately describe the
> structure. Also add a structure that only contains IP header fields
> to be used by functions that don't need UDP.
>

> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Joe Hershberger <joe.hershberger at gmail.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Mike Frysinger <vapier at gentoo.org>
>


I feel that these two changes should be separated.

Also, shouldn't we get rid of the capital letters in the structure names at
this point? Or are you planning on doing that later?

Regards,
Simon


More information about the U-Boot mailing list