[U-Boot] [PATCH v2 10/21] net: cosmetic: Un-typedef Ethernet_t

[Simon Glass]

Hi Joe,

On Wed, Mar 28, 2012 at 12:42 PM, Joe Hershberger <joe.hershberger at ni.com>wrote:

> Separate the Ethernet header from the 802 header.
> Base the size constants on the structs.
>
> Signed-off-by: Joe Hershberger <joe.hershberger at ni.com>
> Cc: Joe Hershberger <joe.hershberger at gmail.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Mike Frysinger <vapier at gentoo.org>
>

How about struct ethernet_hdr? Otherwise it looks good.

Just an aside - I assume that the sizeof() does not word align the result
on any architectures? In other words, does sizeof(struct Ethernet_hdr)
definitely give you 14 instead of 16 in all cases? I am sure this might be
right, or it would have broken things horribly.

Regards,
Simon


> ---
> Changes for v2:
>   - Split apart from "Un-typedef variables in net"
>   - Created a new E802_hdr struct and removed 802 members from Ethernet_hdr
>   - Renamed structs from *_t to *_hdr since they are nolonger types
>   - Replaced offsetof(Ethernet_t, et_dsap) with ETHER_HDR_SIZE in
> arch/powerpc/cpu/mpc8260/ether_fcc.c
>