[U-Boot] [PATCH v2 1/2] CONFIG_SYS_BAUDRATE_TABLE: Add <config_fallbacks.h>, place there

[Tom Rini]

On 04/27/2012 10:19 AM, Wolfgang Denk wrote:
> Dear Tom,
>
> In message<4F9ACDB8.8000705 at ti.com>  you wrote:
>>
>>>> Then we're really SOL here.  Even if we limit it to "I dropped
>>>> 300/600/900/1200/2400/4800 baud rate support, is that ok".
>>>
>>> What's wrong with keeping a customizes #define for the boards that use
>>> nonstandard settings?
>>
>> As I said in the commit message, I believe it was done for completeness
>> rather than need, but if you like I can change it to just delete
>
> As long as we don't know it exactly and for sure, we should not change
> the configuration of boards that don't belong to us (unless the changes
> are obviously harmless or clear bug fixes).

Alright, I'll drop those boards then.

>> 4800/9600/19200/38400/115200 (and reversed) and leave the rest alone.
>> And then I'll drop it from the boards I own :)
>
> OK.
>
>>> But you see the problem in the patch, don't you?
>>
>> With it not applying? No...
>
> Well, your patch reads for example:
>
> diff --git a/include/configs/AP1000.h b/include/configs/AP1000.h
> index b598371..fd074fb 100644
> --- a/include/configs/AP1000.h
> +++ b/include/configs/AP1000.h
> @@ -142,7 +142,6 @@
>   #define CONFIG_SYS_INIT_CHAN2		0
>
>   /* The following table includes the supported baudrates */
> -#undef CONFIG_SYS_BAUDRATE_TABLE
>   #define CONFIG_SYS_BAUDRATE_TABLE  \
>       {300, 600, 1200, 2400, 4800, 9600, 19200, 38400, 57600, 115200, 230400}

guh.. I'll go kick git some then.

-- 
Tom