[U-Boot] [PATCH v2 1/2] CONFIG_SYS_BAUDRATE_TABLE: Add <config_fallbacks.h>, place there

[Wolfgang Denk]

Dear Tom,

In message <4F9ACDB8.8000705 at ti.com> you wrote:
>
> >> Then we're really SOL here.  Even if we limit it to "I dropped
> >> 300/600/900/1200/2400/4800 baud rate support, is that ok".
> >
> > What's wrong with keeping a customizes #define for the boards that use
> > nonstandard settings?
> 
> As I said in the commit message, I believe it was done for completeness 
> rather than need, but if you like I can change it to just delete 

As long as we don't know it exactly and for sure, we should not change
the configurationof boards that don't belong to us (unless the changes
are obviously harmless or clear bug fixes).

> 4800/9600/19200/38400/115200 (and reversed) and leave the rest alone. 
> And then I'll drop it from the boards I own :)

OK.

> > But you see the problem in the patch, don't you?
> 
> With it not applying? No...

Well, your patch reads for example:

diff --git a/include/configs/AP1000.h b/include/configs/AP1000.h
index b598371..fd074fb 100644
--- a/include/configs/AP1000.h
+++ b/include/configs/AP1000.h
@@ -142,7 +142,6 @@
 #define CONFIG_SYS_INIT_CHAN2		0
 
 /* The following table includes the supported baudrates */
-#undef CONFIG_SYS_BAUDRATE_TABLE
 #define CONFIG_SYS_BAUDRATE_TABLE  \
     {300, 600, 1200, 2400, 4800, 9600, 19200, 38400, 57600, 115200, 230400}
 


But include/configs/AP1000.h does not contain any such line as
"#undef CONFIG_SYS_BAUDRATE_TABLE"; the result looks like this:

-> patch -p1 --dry-run <~/Mail/U-Boot/15922
patching file include/config_cmd_defaults.h
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file include/config_cmd_defaults.h.rej
patching file include/config_fallbacks.h
patching file include/configs/AP1000.h
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file include/configs/AP1000.h.rej
patching file include/configs/APC405.h
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file include/configs/APC405.h.rej
...


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The universe does not have laws - it has habits, and  habits  can  be
broken.