[U-Boot] [PATCH V3] i.MX6: mx6q_sabrelite: add SATA bindings

Eric Nelson eric.nelson at boundarydevices.com
Sat Apr 28 17:36:40 CEST 2012


Hi Dirk,

On 04/28/2012 07:51 AM, Dirk Behme wrote:
> Hi Eric,
>
> On 26.04.2012 01:50, Eric Nelson wrote:
>> Signed-off-by: Eric Nelson<eric.nelson at boundarydevices.com>
>>
>> ---
>> V2 has been stripped of the board-independent changes and
>> uses clrsetbits_le32() instead of twiddling bits by hand.
>>
>> V3 returns immediately from setup_sata() if enable_sata_clock()
>> returns an error.
>>
>> board/freescale/mx6qsabrelite/mx6qsabrelite.c | 32 +++++++++++++++++++++++++
>> include/configs/mx6qsabrelite.h | 13 ++++++++++
>> 2 files changed, 45 insertions(+), 0 deletions(-)
>>
>> diff --git a/board/freescale/mx6qsabrelite/mx6qsabrelite.c
>> b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
>> index 1d09a72..c9a108f 100644
>> --- a/board/freescale/mx6qsabrelite/mx6qsabrelite.c
>> +++ b/board/freescale/mx6qsabrelite/mx6qsabrelite.c
>> @@ -25,6 +25,8 @@
>> #include<asm/arch/imx-regs.h>
>> #include<asm/arch/mx6x_pins.h>
>> #include<asm/arch/iomux-v3.h>
>> +#include<asm/arch/ccm_regs.h>
>
> Do we need ccm_regs.h here?
>

Nope. Good catch.

I'll generate a V4 in a day or two to allow some other review.

Stefano, what's the status of the dwc_ahsata driver?

Without that, the bindings are clearly useless.

Regards,


Eric


More information about the U-Boot mailing list