[U-Boot] [PATCH 1/2] GCC47: Fix warning in cmd_nand.c

Wolfgang Denk wd at denx.de
Sun Apr 29 14:11:53 CEST 2012


Dear Marek Vasut,

In message <1335652120-2646-1-git-send-email-marex at denx.de> you wrote:
> cmd_nand.c: In function ‘arg_off_size’:
> cmd_nand.c:216:5: warning: ‘maxsize’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> 
> Signed-off-by: Marek Vasut <marex at denx.de>
> Cc: Scott Wood <scottwood at freescale.com>
> Cc: Wolfgang Denk <wd at denx.de>
> ---
>  common/cmd_nand.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.


> NOTE: Why does this emit these blahs about UTF8? I just noticed git started
> behaving weird on me, anyone can give me a hint how to disable these?

Yes, I think I can: don't use funny characters like these quotes
around "arg_off_size" and "maxsize" in the commit messages. You will
also notice that patchwork has problems with these, like here:

Traceback (most recent call last):
  File "/home/wd/bin/pwclient", line 466, in <module>
    main()
  File "/home/wd/bin/pwclient", line 449, in main
    action_apply(rpc, patch_id)
  File "/home/wd/bin/pwclient", line 264, in action_apply
    proc.communicate(s)
  File "/usr/lib64/python2.7/subprocess.py", line 737, in communicate
    self.stdin.write(input)
UnicodeEncodeError: 'ascii' codec can't encode character u'\u2018' in position 450: ordinal not in range(128)



Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Anarchy may not be the best form of government, but it's better  than
no government at all.


More information about the U-Boot mailing list