[U-Boot] [PATCH 1/2] GCC47: Fix warning in cmd_nand.c
Marek Vasut
marex at denx.de
Sun Apr 29 15:11:36 CEST 2012
Dear Wolfgang Denk,
> Dear Marek Vasut,
>
> In message <1335652120-2646-1-git-send-email-marex at denx.de> you wrote:
> > cmd_nand.c: In function ‘arg_off_size’:
> > cmd_nand.c:216:5: warning: ‘maxsize’ may be used uninitialized in this
> > function [-Wmaybe-uninitialized]
> >
> > Signed-off-by: Marek Vasut <marex at denx.de>
> > Cc: Scott Wood <scottwood at freescale.com>
> > Cc: Wolfgang Denk <wd at denx.de>
> > ---
> >
> > common/cmd_nand.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Applied, thanks.
>
> > NOTE: Why does this emit these blahs about UTF8? I just noticed git
> > started behaving weird on me, anyone can give me a hint how to disable
> > these?
>
> Yes, I think I can: don't use funny characters like these quotes
> around "arg_off_size" and "maxsize" in the commit messages.
Looking closer at it, it's not standard "'" quote character, what the heck. But
$LANG (and $LANGUAGE) is set to en_US.UTF8 . Damned, I'll try to find the root
cause, but I feel like overcomplicated KDE4 combined with who-knows-what will
win this battle :-/
> You will
> also notice that patchwork has problems with these, like here:
>
> Traceback (most recent call last):
> File "/home/wd/bin/pwclient", line 466, in <module>
> main()
> File "/home/wd/bin/pwclient", line 449, in main
> action_apply(rpc, patch_id)
> File "/home/wd/bin/pwclient", line 264, in action_apply
> proc.communicate(s)
> File "/usr/lib64/python2.7/subprocess.py", line 737, in communicate
> self.stdin.write(input)
> UnicodeEncodeError: 'ascii' codec can't encode character u'\u2018' in
> position 450: ordinal not in range(128)
>
>
>
> Best regards,
>
> Wolfgang Denk
Best regards,
Marek Vasut
More information about the U-Boot
mailing list