[U-Boot] [PATCHv2] at91: Add support for taskit AT91SAM9G20 boards.

[Markus Hubig]

On Wed, Aug 01, 2012 at 10:59:10PM +0200, Andreas Bießmann wrote:
> On 01.08.12 21:57, Markus Hubig wrote:
> > +Markus Hubig <mhubig at imko.de>
> > +
> > +	STAMP9G20	ARM926EJS
> > +
> >  Ilko Iliev <iliev at ronetix.at>
> 
> unfortunately Ilko Iliev is wrong here ... this is the PPC section (all
> these MPCxx). About line 566 begins the ARM section.

Moved both of us ...

> > + * RAM Memory address where to put the
> > + * Linux Kernel bevor starting.
> --------------------^
> before?

Ups ...

> > +	"mtdparts=mtdparts=atmel_nand:128k(bootstrap)ro,"		\
> > +		"256k(uboot)ro,128k(env1)ro,"				\
> > +		"128k(env2)ro,12M(linux),-(root)rw\0"			\
> 
> your table in comment tells 6MiB for kernel, here you have 12MiB ;)

Grrr fixed! ;)

> > +	"nfsboot=dhcp; setenv bootargs ${basicargs} ${mtdparts} "	\
> > +		"root=/dev/nfs ip=dhcp; bootm\0"
> 
> dhcp command can use some env (I think bootfile) to directely boot. So
> setting this env, setting bootargs and then run dhcp would maybe better.
> Alternatively the nfsboot could imply a correctly set bootfile, this
> could be another env in your EXTRA_ENV_SETTINGS (another side note;).

Ahh it's autoboot=yes! ;)

Btw: I think it would be easier to handle if all the options in
env_common.h would be prefixed with CONFIG_ENV_* ...

> > +#endif /* __CONFIG_H */
> > 
> 
> We should think about the MACB ifdef stuff again. I learned that the
> stamp9g20 is a small device sitting on different base boards. In case of
> portux9g20 we will have ethernet. Therefore we should always enable MACB
> when we are configured as portux9g20. But if one uses the stamp on
> another base board he maybe want to disable ethernet support easily ...
> with this information I think it is good to have these ifdef blocks
> around all the ethernet stuff. Sorry, I understood this in your last
> mail and you sent this patch to fast to comment ...

Hmm ok good idea ... will include this in the next patch.

Cheers, Markus