[U-Boot] [PATCH 1/1] lib, panic: don't call do_reset in SPL (debug).

Tom Rini trini at ti.com
Wed Aug 15 19:11:18 CEST 2012


On Tue, Aug 14, 2012 at 10:40:50PM +0200, Jeroen Hofstee wrote:

> Several omap boards won't build when DEBUG is defined, SPL build error:
> "vsprintf.c:791: undefined reference to `do_reset'", since SPL has no
> commands. Therefore don't call do_reset in SPL. SPL panic will end in an
> endless loop or call hang if CONFIG_PANIC_HANG is defined.
> 
> cc: Tom Rini <trini at ti.com>
> Signed-off-by: Jeroen Hofstee <jhofstee at victronenergy.com>

OK, the problem I see with this is it forces a policy on everyone, even
non-DEBUG cases.  What I'd like to see, and I'll submit the patch, is to
document that when debugging SPL one should also set CONFIG_PANIC_HANG
as do_reset is often (but it could be defined!) undefined for SPL.

-- 
Tom


More information about the U-Boot mailing list