[U-Boot] [PATCH 1/1] lib, panic: don't call do_reset in SPL (debug).

[Stefano Babic]

On 15/08/2012 19:11, Tom Rini wrote:
> On Tue, Aug 14, 2012 at 10:40:50PM +0200, Jeroen Hofstee wrote:
> 
>> Several omap boards won't build when DEBUG is defined, SPL build error:
>> "vsprintf.c:791: undefined reference to `do_reset'", since SPL has no
>> commands. Therefore don't call do_reset in SPL. SPL panic will end in an
>> endless loop or call hang if CONFIG_PANIC_HANG is defined.
>>
>> cc: Tom Rini <trini at ti.com>
>> Signed-off-by: Jeroen Hofstee <jhofstee at victronenergy.com>
> 
> OK, the problem I see with this is it forces a policy on everyone, even
> non-DEBUG cases.  What I'd like to see, and I'll submit the patch, is to
> document that when debugging SPL one should also set CONFIG_PANIC_HANG
> as do_reset is often (but it could be defined!) undefined for SPL.

Right, we have some kind of dependencies. It is always painful if the
reason is unknown, and we should document it.

Best regards,
Stefano



-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================