[U-Boot] [PATCH 01/10] ARM: dove: add support for Marvell Dove SoC

Luka Perkov luka at openwrt.org
Sun Dec 2 20:03:13 CET 2012


Hi Sebastian,

On Sun, Dec 02, 2012 at 03:36:13PM +0100, Sebastian Hesselbarth wrote:
> This patch adds initial support for the armv7-based Marvell Dove SoC
> (88AP510).
> 
> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth at gmail.com>

...

> +	for (; i < CONFIG_NR_DRAM_BANKS; i++) {
> +		/* If above loop terminated prematurely, we need to set
> +		 * remaining banks' start address & size as 0. Otherwise other
> +		 * u-boot functions and Linux kernel gets wrong values which
> +		 * could result in crash */

Please fix this comment style.

...

> +	/* configure gpio capabilities */
> +	/* gpio allows gpio on all audio1 mpp pins */

Here too.

Also, your patch to MAINTAINERS file is missing...

Luka


More information about the U-Boot mailing list