[U-Boot] [PATCH 10/10] tools: Add support for Dove to kwboot

[Daniel Stodden]

On Sun, 2012-12-02 at 20:15 +0100, Luka Perkov wrote:
> Hi Sebastian,
> 
> On Sun, Dec 02, 2012 at 03:36:22PM +0100, Sebastian Hesselbarth wrote:
> > On Dove kwboot can also be used to boot an u-boot image into RAM.
> > In contrast to Kirkwood, Dove does not support the UART boot mode
> > sequence but requires the UART boot mode to be selected through
> > strap pins. The SolidRun CuBox has a push button to allow uart
> > boot mode but fails on the boot sequence sent by kwboot.
> > 
> > This patch adds another cmdline option to allow to send a boot
> > image without the boot sequence and adds support for Dove.
> > 
> > Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth at gmail.com>
> > ---
> > Cc: u-boot at lists.denx.de
> > Cc: Sebastian Hesselbarth <sebastian.hesselbarth at gmail.com>
> > Cc: Rabeeh Khoury <rabeeh at solid-run.com>
> > Cc: Albert Aribaud <albert.u.boot at aribaud.net>
> > Cc: Prafulla Wadaskar <prafulla at marvell.com>
> > Cc: Andy Fleming <afleming at gmail.com>
> > Cc: Joe Hershberger <joe.hershberger at gmail.com>
> > Cc: Daniel Stodden <daniel.stodden at gmail.com>
> > Cc: Dieter Kiermaier <dk-arm-linux at gmx.de>
> > ---
> >  tools/Makefile |    2 ++
> >  tools/kwboot.c |   44 ++++++++++++++++++++++++++++++++++++++++----
> >  2 files changed, 42 insertions(+), 4 deletions(-)
> 
> Please update the documentation too (doc/kwboot.1).

Second that.

Hey Sebastian,

since the protocol remains the same, and just doesn't take a boot
message while polling, better to keep the bootmsg_call() intact and just
make the option parsing flip the message type?

The original BootROM had a couple more message, the tool just no
immediate use for that. Eventual options to change message type wasn't
unanticipated. Ok, no message at all was.

Sketchy patch attached for your consideration. Beware, I can't test it
right now.

Also, while I've got nothing against adding a flag for that, I'm partly
wondering whether this took a patch at all -- what's the target behavior
if you keep shooting it with the original boot message?

I would assume it would keep responding with NAKs. But doesn't?

Cheers,
Daniel 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-patch
Size: 1266 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121205/e8935a15/attachment.bin>