[U-Boot] [PATCH 07/11] usb: usbeth: smsc95xx: remove EEPROM loaded check

Marek Vasut marex at denx.de
Thu Dec 13 18:35:31 CET 2012


Dear Simon Glass,

> From: Michael Spang <spang at chromium.org>
> 
> [port of Linux kernel commit bcd218be5aeb by Steve Glendinning]
> 
> The eeprom read & write commands currently check the E2P_CMD_LOADED_ bit is
> set before allowing any operations.  This prevents any reading or writing
> unless a correctly programmed EEPROM is installed.
> 
> Signed-off-by: Michael Spang <spang at chromium.org>
> Signed-off-by: Simon Glass <sjg at chromium.org>

Acked-by: Marek Vasut <marex at denx.de>

> ---
>  drivers/usb/eth/smsc95xx.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/eth/smsc95xx.c b/drivers/usb/eth/smsc95xx.c
> index dc5ca65..fd8f8a7 100644
> --- a/drivers/usb/eth/smsc95xx.c
> +++ b/drivers/usb/eth/smsc95xx.c
> @@ -265,10 +265,6 @@ static int smsc95xx_eeprom_confirm_not_busy(struct
> ueth_data *dev)
> 
>  	do {
>  		smsc95xx_read_reg(dev, E2P_CMD, &val);
> -		if (!(val & E2P_CMD_LOADED_)) {
> -			debug("No EEPROM present\n");
> -			return -1;
> -		}
>  		if (!(val & E2P_CMD_BUSY_))
>  			return 0;
>  		udelay(40);

Best regards,
Marek Vasut


More information about the U-Boot mailing list