[U-Boot] [PATCH 1/9] mx28evk: We shouldn't hardcode a rootfs filesystem type

[Wolfgang Denk]

Dear Stefano Babic,

In message <50DC15E3.2040003 at denx.de> you wrote:
>
> Well, I think you can add extra tabs to make it more readable:
> 
> +       "mmcargs=setenv bootargs console=${console_mainline},"\
> +		" ${baudrate} root=${mmcroot}\0" \

That should be

		"${baudrate} root=${mmcroot}\0" \
	
i. e. without a space after the opening '"'.


Otavio:  It may also help to chose somewhat shorter variable names -
this also helps the end user; "console_mainline" is a terribly ling
variable name, and I don't consider it a good choice either.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
For every complex problem, there is a solution that is simple,  neat,
and wrong.                                               - Mark Twain