[U-Boot] [PATCH 1/9] mx28evk: We shouldn't hardcode a rootfs filesystem type

[Otavio Salvador]

On Thu, Dec 27, 2012 at 8:29 AM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Stefano Babic,
>
> In message <50DC15E3.2040003 at denx.de> you wrote:
>>
>> Well, I think you can add extra tabs to make it more readable:
>>
>> +       "mmcargs=setenv bootargs console=${console_mainline},"\
>> +             " ${baudrate} root=${mmcroot}\0" \
>
> That should be
>
>                 "${baudrate} root=${mmcroot}\0" \
>
> i. e. without a space after the opening '"'.

I did a similar change and will send a v2.

> Otavio:  It may also help to chose somewhat shorter variable names -
> this also helps the end user; "console_mainline" is a terribly ling
> variable name, and I don't consider it a good choice either.

Yes I agree; in fact I still wish to rework the environment and have
it common to most Freescale boards in future but I'll look into that
later.

--
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br