[U-Boot] [PATCH V3 1/9] FDT: Add compatible string for DWMMC

Kyungmin Park kmpark at infradead.org
Mon Dec 31 13:35:02 CET 2012


Hi,


On Mon, Dec 31, 2012 at 7:58 PM, Amar <amarendra.xt at samsung.com> wrote:
> Add required compatible information for DWMMC driver.
>
> Changes from V1:
>         No change.
>
> Changes from V2:
>         1)Updation of commit message and resubmition of proper patch set.
>
> Signed-off-by: Vivek Gautam <gautam.vivek at samsung.com>
> Signed-off-by: Amar <amarendra.xt at samsung.com>
> Acked-by: Simon Glass <sjg at chromium.org>
> ---
>  include/fdtdec.h | 1 +
>  lib/fdtdec.c     | 1 +
>  2 files changed, 2 insertions(+)
>
> diff --git a/include/fdtdec.h b/include/fdtdec.h
> index ce10bf4..dcd4142 100644
> --- a/include/fdtdec.h
> +++ b/include/fdtdec.h
> @@ -76,6 +76,7 @@ enum fdt_compat_id {
>         COMPAT_SAMSUNG_EXYNOS5_SOUND,   /* Exynos Sound */
>         COMPAT_WOLFSON_WM8994_CODEC,    /* Wolfson WM8994 Sound Codec */
>         COMPAT_SAMSUNG_EXYNOS_SPI,      /* Exynos SPI */
> +       COMPAT_SAMSUNG_EXYNOS5_DWMMC,   /* Exynos5 DWMMC controller */

You already know that exynos4 series also have DWMMC controller and
it's strange to use this value at exynos4 series.
so can you use 'SAMSUNG_EXYNOS_DWMMC'?

Thank you,
Kyungmin Park
>
>         COMPAT_COUNT,
>  };
> diff --git a/lib/fdtdec.c b/lib/fdtdec.c
> index aa75710..646d5d6 100644
> --- a/lib/fdtdec.c
> +++ b/lib/fdtdec.c
> @@ -51,6 +51,7 @@ static const char * const compat_names[COMPAT_COUNT] = {
>         COMPAT(SAMSUNG_EXYNOS5_SOUND, "samsung,exynos-sound"),
>         COMPAT(WOLFSON_WM8994_CODEC, "wolfson,wm8994-codec"),
>         COMPAT(SAMSUNG_EXYNOS_SPI, "samsung,exynos-spi"),
> +       COMPAT(SAMSUNG_EXYNOS5_DWMMC, "samsung,exynos5250-dwmmc"),
>  };
>
>  const char *fdtdec_get_compatible(enum fdt_compat_id id)
> --
> 1.8.0
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot


More information about the U-Boot mailing list