[U-Boot] [PATCH v3 5/5] i.mx6q: mx6qsabrelite: Update the network configuration

[Jason Hui]

Troy,

On Thu, Feb 2, 2012 at 9:37 AM, Troy Kisky
<troy.kisky at boundarydevices.com> wrote:
> On 2/1/2012 6:14 PM, Troy Kisky wrote:
>>
>> +       ksz9021_phy_write(phydev, 0, 0x105, 0x0);       /* min rx data
>> delay */
>> +       ksz9021_phy_write(phydev, 0, 0x106, 0x0);       /* min tx data
>> delay */
>> +       /* max rx/tx clock delay, min rx/tx control */
>> +       ksz9021_phy_write(phydev, 0, 0x104, 0xf0f0);
>> +       if (phydev->drv->config)
>> +               phydev->drv->config(phydev);
>>
> I didn't notice this warning before
>
> mx6qsabrelite.c:244: warning: implicit declaration of function
> 'ksz9021_phy_write'
>
> Can I add this definition to mx6qsabrelite.c?

Definition or declaration? If the function only used by sabrelite board,
you can move the definition to mx6qsabrelite.c. If it has more users,
you need add it to one head file and include this head file in mx6qsabrelite.c.

I searched u-boot and find only sabrelite board use ksz9021_phy_write, so
you can move the definition here.

>
> checkpatch says it should be in a .h file.
>
>
> I'll resend just 5/5 if nobody spots other issues.

Please had better re-post the whole patch-set to facilitate the
user(at least me) to apply the patch and test.
And please make sure you don't break i.mx6qarm2 board. Thanks,

>
> Troy
>