[U-Boot] [PATCH 1/2] i.MX28: Fix ref_cpu clock setup

[Fabio Estevam]

Hi Robert,

On 2/2/12, Robert Deliën <robert at delien.nl> wrote:
> Hi,
>
> This patch fixes ref_cpu clock setup. This bug leads to a hanging board
> after rebooting from the Kernel, due to failing memory size detection:
> U-Boot 2011.12-svn342 (Feb 02 2012 - 17:20:00)
>
>
> Freescale i.MX28 family
>
> I2C:   ready
>
> DRAM:  0 Bytes
>
>
> The cause of the bug is register hw_clkctrl_frac0 being accessed as
> a 32-bit long, whereas the manual specifically states it can be accessed
> as bytes only.
> Applying this patch fixes this problem.
>
> Signed-off-by: Robert Delien (robert at delien.nl)

Very good, Robert! I tested your patch and it fixes the reboot issue
on my mx28evk.

Also checked in the MX28 Reference Manual about the fact that
hw_clkctrl_frac0 can only be accessed as bytes.

I have some suggestions though:

1. Your patch comes as attachment. Please use git send-email instead.

2. Please grep the locations where hw_clkctrl_frac0 is assigned as
32-bit and change those as well.

3. Send the two patches in a series via git send-email: 1/2 and 2/2

Good to know that you fixed the stepping issue as well. Good work!

Regards,

Fabio Estevam