[U-Boot] [PATCH 1/1] arm: mmc: omap: spl size reduction by removing write/erase ops

[Tom Rini]

On Thu, Feb 2, 2012 at 9:48 AM, Aneesh V <aneesh at ti.com> wrote:
> Tom,
>
>
> On Thursday 02 February 2012 10:02 PM, Tom Rini wrote:
>>
>> On Thu, Feb 2, 2012 at 6:04 AM, Balaji T K<balajitk at ti.com>  wrote:
>>>
>>> spl for OMAP4 does not use mmc read/write.
>>> Add CONFIG_MMC_NO_ERASE, CONFIG_MMC_NO_WRITE to platforms where mmc
>>> write/erase operation is not needed in spl.
>>> Use these CONFIGS to remove write/erase code in mmc.c and omap_hsmmc.c
>>> This reduces the spl size by ~1128 Bytes
>>
>>
>> Are you running into a size limitation again?  If not, I think we want
>
> We are always on the border. Minor fluctuations are affecting us. And
> our EMU boards(secure devices) are permanently broken due to this. I am
> not sure if this one helps EMU devices though.

Ick, OK.  So lets re-do this for now with #define CONFIG_FOO not
#define CONFIG_FOO 1 and push for this going in now to solve problems
with real devices.

>> to wait until we sort out how SPL includes/excludes stuff moving
>> forward as this shows there's probably a lot of other unused code
>> being pulled in.
>>
>
> We use -ffunction-sections -fdata-sections and --gc-sections while
> building SPL. So, un-necessary stuff will not be included unless the
> function pointers are set in some structures and not used. I think that
> is what is happening in this case. Other than that I am not expecting
> much scope for improvement.

Exactly.  I think part of the problem is that this discussion is
buried in the thread about SPL YMODEM support, but Wolfgang isn't
happy with some of the direction SPL stuff is heading.

-- 
Tom